BaGet icon indicating copy to clipboard operation
BaGet copied to clipboard

Published 20 hours ago • verified publisher icon loic-sharma

Fix package filtering with TableSearchService

Open yang-er opened this issue 4 years ago • 2 comments

Support filtering TargetFrameworks and PackageType in BaGet.Azure.TableSearchService in backend service.

yang-er avatar Aug 17 '20 13:08 yang-er

Hi, thanks for sending this contribution! Could you explain a little more why you'd like to add this? This won't work as expected with the skip and take parameters. Support all search features using the Azure Table search service is extremely difficult, I was planning on supporting additional features. Happy to hear your thoughts though! :)

loic-sharma avatar Aug 19 '20 06:08 loic-sharma

Currently if we couldn't implement the searching well with Azure Tables, we have two choices:

  • To show correct search results, but each page loses several items.
  • To show correct numbers of items, but the search result is not filtered.

I think the first choice is much better than the second one. The first one may mislead users but the second one only requires users to navigate more pages to see the results.

yang-er avatar Aug 19 '20 07:08 yang-er