apollo icon indicating copy to clipboard operation
apollo copied to clipboard

Missing tests - because Kubernetes mock is deprecated

Open ShaharGotshtat opened this issue 7 years ago • 2 comments

Since Kubernetes mock is deprecated, it's super hard to write some tests that we would like to write:

  1. StatusController:
    • GetCurrentServiceStatus.
    • GetCurrentEnvironmentStatus.
    • GetLatestPodName (with and without groupId).
    • GetPodContainers.
  2. ScalingController:
    • UpdateScalingFactor.
  3. EnvStatus (DeploymentEnvStatusManager):
    • When having another service in the same environment and it is part of a group.
  4. HealthController:
    • Detect unhealthy environment.
  5. KubernetesActionsController:
    • Restart pod.
    • Restart all pods.
  6. Limit concurrent deployment based on environment setting

ShaharGotshtat avatar Jan 14 '18 12:01 ShaharGotshtat

We should refactor these tests and make them E2E tests and run them with k8s cluster on travis-ci: https://medium.com/@cedriclam/how-to-run-e2e-tests-against-a-kubernetes-cluster-with-travis-ci-628237ac8fbe

asafalima avatar Jan 30 '18 19:01 asafalima

Yep, that's the plan

roiravhon avatar Jan 31 '18 08:01 roiravhon