logstash-output-s3 icon indicating copy to clipboard operation
logstash-output-s3 copied to clipboard

Published 20 hours ago • verified publisher icon logstash-plugins

add 2 features in s3 output plugin

Open cnhappier opened this issue 10 years ago • 6 comments

  1. make codec configurable
  2. move file to bucket in graceful shutdown

cnhappier avatar Apr 17 '15 07:04 cnhappier

  1. is covered in logstash/outputs/base

  2. I would argue should be a configuration. Forcing a flush may not always be desirable.

dmlogs avatar May 29 '15 23:05 dmlogs

according to dmlogs's comment, add move_file_to_bucket flag to disable the move file in shutdown

cnhappier avatar Jun 02 '15 09:06 cnhappier

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

elasticsearch-release avatar Nov 02 '15 11:11 elasticsearch-release

@cnhappier can you sign the CLA in order to get this integrated?

runningman84 avatar Sep 30 '16 08:09 runningman84

@karmi @runningman84 I've signed the CLA, how can I continue to merge this?

cnhappier avatar Oct 01 '16 19:10 cnhappier

@cnhappier looks like there's a merge conflict now. If that gets fixed is this in a good place to merge? This would be very useful. Another thought: what if this was updated to upload all files in the persisted queue to S3?

chadbean avatar Feb 24 '17 17:02 chadbean