logstash-input-http icon indicating copy to clipboard operation
logstash-input-http copied to clipboard
verified publisher icon logstash-plugins

Cleanup to match best practices in ruby and shell

Open teancom opened this issue 7 years ago • 3 comments

Cleanup both ruby and shell scripts to match various linters' suggestions. Mostly using the new hash syntax, as well as small readability changes. Additionally, update gitignore to not accidentally add in the output from running rake vendor

This was done as a "slate-cleaning" and a way to learn the repo before starting any of the issues marked "hacktober".

teancom avatar Oct 23 '18 03:10 teancom

The CI build failed but it appears like it was due to connectivity issues. Is that something that just needs to be kicked off again?

teancom avatar Oct 23 '18 15:10 teancom

Thanks for the PR @teancom, I have restarted the tests in travis

jsvd avatar Oct 23 '18 15:10 jsvd

I reverted/cleaned up the issues you found, squashed, and repushed. Let me know if it looks better now. Thank you for taking the time to review!

teancom avatar Oct 23 '18 22:10 teancom