logstash-input-file icon indicating copy to clipboard operation
logstash-input-file copied to clipboard

Change "sincedb_clean_after" defaults

Open fbaligand opened this issue 6 years ago • 0 comments

The new option sincedb_clean_after is great ! But I would appreciate some slight changes :

  • define the value in seconds, as it is the case for all the 5 other options that deal with a duration.
  • set no default value. It allows to have same behavior for people that just update Logstash and implies no bug if start_option => begininng is set and no ignore_older. It gives also the ability to not activate the option for Logstash users who don't want sincedb auto-cleanup. Endly, it allows to have a consistent default behavior between ignore_older and sincedb_clean_after options, that are tied.
  • precise in the documentation that this option should be higher than ignore_older option, to have a consistent behavior.

fbaligand avatar May 01 '18 13:05 fbaligand