logstash-filter-translate icon indicating copy to clipboard operation
logstash-filter-translate copied to clipboard

Rename this plugin

Open suyograo opened this issue 9 years ago • 7 comments

Translate as a name is not apt for this plugin. It does more than translate and probably be named logstash-filter-lookup or something. Thoughts? Is lookup too generic?

suyograo avatar Jul 22 '15 16:07 suyograo

I like lookup. At least it gives an idea that this is a more generic plugin.

@suyograo :+1: :smile:

gmoskovicz avatar Jul 22 '15 16:07 gmoskovicz

+1

dadoonet avatar Aug 28 '15 07:08 dadoonet

I like the renaming, this recall me to a dictionary lookup, that is what this plugin mostly does :smile:

purbon avatar Aug 28 '15 07:08 purbon

@suyograo I like it too

maybe hashlookup is a good tag.

dictionary lookups improve speed incredibly. We just pushed 50% more logs p/second in Elasticsearch using a hash lookup with translation.

jelmerdereus avatar Jan 05 '16 13:01 jelmerdereus

@jelmerdereus - this is good to hear. Please add some detail of what you had before and after.

guyboertje avatar Mar 10 '16 14:03 guyboertje

@guyboertje it did a lookup real fast but no translation was done before transmitting it over the network. It was faster because it did less work. My apologies for not correcting that in this issue before.

In the next weeks I will get time from my employer to delve into this. When we reach the required performance, I'll let you know how.

jelmerdereus avatar Mar 10 '16 14:03 jelmerdereus

@jelmerdereus - Sorry I don't understand. Are you saying that the latest version is faster than previously or that a different config (say using mutate) was slower that a newer config using translate?

guyboertje avatar Mar 10 '16 16:03 guyboertje