grok Pattern in file, should trim ending spaces

[jordansissel]

(This issue was originally filed by @woodyyou at https://github.com/elastic/logstash/issues/1843)

---

I put grok patterns in a file, didn't realized there was a space at the end. It resulted not match. Took me quite some time to figure out that's the problem (need to use rubydebug to tell there's a parsing error, even -v didn't tell).

Since leading spaces do not matter, ending space should not either. Also, I think it's a common mistake.

[jordansissel]

I don't know what backwards incompatibility we would cause by introducing this change. It would be useful to know if anyone is relying on trailing whitespace in their patterns.

[woodyyou]

Not anyone I know here relying on the trailing spaces.  Since it's not easily visible, don't think any good practice will use it.

Sent from my Verizon Wireless 4G LTE smartphone

-------- Original message -------- From: Jordan Sissel [email protected] Date: 08/07/2015 5:24 PM (GMT-05:00) To: logstash-plugins/logstash-filter-grok [email protected] Cc: woodyyou [email protected] Subject: Re: [logstash-filter-grok] grok Pattern in file, should trim ending spaces (#36)

I don't know what backwards incompatibility we would cause by introducing this change. It would be useful to know if anyone is relying on trailing whitespace in their patterns.

— Reply to this email directly or view it on GitHub.