aurora icon indicating copy to clipboard operation
aurora copied to clipboard

Backward compatibility

Open logrusorgru opened this issue 6 years ago • 7 comments

The v1.1 should be backward compatible with previous Aurora implementation. Please, let me know if the v1.1 breaks something.

logrusorgru avatar Apr 17 '19 12:04 logrusorgru

cannot use aurora.NewAurora(false).Gray (type func(uint8, interface {}) aurora.Value) as type func(interface {}) aurora.Value in assignment

WGH- avatar Apr 23 '19 21:04 WGH-

Hello, @WGH- , I've renamed v1.1 to v2.0. For now v1.0 is old (initial) version of the Aurora. Please, use

"gopkg.in/logrusorgru/aurora.v1"

import path.

GoDoc documentation.

logrusorgru avatar Apr 24 '19 19:04 logrusorgru

Hi @logrusorgru, regarding @WGH-'s example, do you plan to document changes to the API? For example, BgGray now requires 2 arguments instead of 1.

ryanavella avatar May 29 '19 05:05 ryanavella

Hello, @ryanavella, please take a look at this paragraph: Grayscale. A Gray and a BgGray method require gray color index (from 0 to 23 inclusive) and value to make it gray. There is GoDoc documentations. Zero is black, 23 is white.

If a Gray or BgGray receive gray color out of the [0; 23] range, then nearest valid value used instead.

The Gray and BgGray methods are the same as Index and BgIndex where [0; 23] becomes [232; 255]. It's just 8-bit ANSI colors.

Also, there is CHANGELOG.md


Previous Gray and BgGray methods are now called White and BgWhite following specification. Also, Brown and BgBrown is now Yellow and BgYellow. There are Brown and BgBrown but they are marked as deprecated.

logrusorgru avatar May 29 '19 16:05 logrusorgru

If a Gray or BgGray receive gray color out of the [0; 23] range, then nearest valid value used instead.

Going to change it and introduce GrayScale and BgGrayScale. To make method names a bit intuitive.

Ref.: https://github.com/logrusorgru/aurora/issues/15

P.S.: rejected, nothing will be changed

logrusorgru avatar Feb 08 '20 06:02 logrusorgru

Seems, we need the gorename tool working with go modules, to make the changes.

logrusorgru avatar Feb 08 '20 06:02 logrusorgru

License has changed from the WTFPL to the Unlicense due to pkg.go.dev restriction. I hope no one is against it.

logrusorgru avatar Jul 02 '20 16:07 logrusorgru