bmclib icon indicating copy to clipboard operation
bmclib copied to clipboard

Idfix

Open khaefeli opened this issue 7 years ago • 4 comments

#35 allow setting the user id over the resource. and workaround the issue with empty usernames & the default anonymous user (be careful here!)

khaefeli avatar Jan 03 '18 15:01 khaefeli

Thanks for the flurry of PRs. I'll need to update the travis file unless you can fix the .travis in a new PR. Also since these changes require Facter with structured facts we need to communicate that in the readme and metadata file. We should be targeting Puppet 4.x+ anyways. Please create a CHANGELOG.md and CONTRIBUTORS.md. Add your fixes to Changelog and throw your name/email in the CONTRIBUTORS file.

logicminds avatar Jan 03 '18 17:01 logicminds

I've updated the .travis.yml and removed the ruby 1.9.3 support. tests are running now, but many errors ;)

I can create the changelog and contributors files, should we target v 1.0 and support Puppet 4.x+ without or without older versions?

khaefeli avatar Jan 04 '18 09:01 khaefeli

Please target a 1.0 release

logicminds avatar Jan 30 '18 19:01 logicminds

We can also target ruby 2.1.9 and ruby 2.4.3

logicminds avatar Jan 30 '18 19:01 logicminds