feature-store-api
feature-store-api copied to clipboard
[FSTORE-1008] enable interacting with java client to hopsworks
This PR adds/fixes/changes...
- please summarize your changes to the code
- and make sure to include all changes to user-facing APIs
JIRA Issue: -
Priority for Review: -
Related PRs: -
How Has This Been Tested?
- [ ] Unit Tests
- [ ] Integration Tests
- [ ] Manual Tests on VM
Checklist For The Assigned Reviewer:
- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)
When I was testing it, I found a bug. Can you change line 215 in VectorServer
to
String zippedTupleString =
zipArraysToTupleString(preparedStatementParameters.get(fgId)
.entrySet()
.stream()
.sorted(Comparator.comparingInt(Map.Entry::getValue))
.map(e -> entry.get(e.getKey()))
.collect(Collectors.toList()));
Basically, the problem is that when there are multiple primary key, they need to be sorted according to the index of preparedStatementParameters