logstash-logback-encoder icon indicating copy to clipboard operation
logstash-logback-encoder copied to clipboard

Published 20 hours ago • verified publisher icon logfellow

`getFieldValue()` is not accessible

Open diegomarquezp opened this issue 2 years ago • 2 comments

Hello, since 7.1 we are having issues in our test code that deals with getFieldValue() (tracked in https://github.com/GoogleCloudPlatform/spring-cloud-gcp/issues/1764). This method was declared protected in https://github.com/logfellow/logstash-logback-encoder/pull/720 , apparently only intended to change the return type of this method. Is it possible to change it back to public?

Thank you!

diegomarquezp avatar Oct 03 '23 14:10 diegomarquezp

Hi @diegomarquezp

The marker classes are not currently designed to be consumed outside of logstash-logback-encoder. Backwards compatibility is not guarenteed for them. They are public only because the library needs to access them from a different package (net.logstash.logback.argument) for structured arguments.

Can you provide some more details about why you need to access them?

philsttr avatar Oct 03 '23 16:10 philsttr

At least we are using them in unittests too, to see if some MDC fields have been logged.

david0 avatar May 02 '24 09:05 david0