logdna-winston icon indicating copy to clipboard operation
logdna-winston copied to clipboard

`_final` callback removed

Open lgfa29 opened this issue 5 years ago • 2 comments

A while back I submitted a PR to fix Winston 3 support, but part of my PR was removed, more specifically that part that implemented the _final callback to flush messages when the transport closes.

I added a comment to the commit but it seems to not have enough visibility.

Would it possible to get the _final callback back in place? It's extremely import in my use case where I am using Open Whisk so I need to flush the messages before my action gets terminated and I lose important log messages.

Thank you.

lgfa29 avatar Apr 09 '19 21:04 lgfa29

For more information on _final in Winston, check https://github.com/winstonjs/winston/pull/1346/ and https://github.com/winstonjs/winston-transport/pull/24/files

lgfa29 avatar Apr 09 '19 21:04 lgfa29

@respectus @LYHuang any chance someone could you take a look at this?

lgfa29 avatar Jun 03 '19 22:06 lgfa29