logdna-winston icon indicating copy to clipboard operation
logdna-winston copied to clipboard

Published 20 hours ago • verified publisher icon logdna

new code block with error handling LOG-9481

Open tanberry opened this issue 3 years ago • 5 comments

Per Jira LOG-9481, Braxton reworked code example to include error handling best practice.

tanberry avatar Apr 16 '21 02:04 tanberry

What happened to the other change? There's only 1 now. Did you force push over it, @tanberry ?

darinspivey avatar Apr 16 '21 14:04 darinspivey

Sorry about that @darinspivey; I attempted to use the "Commit suggestion" button on the UI for both of your edits, and I don't think it worked for one of them. SoI made the changes locally and pushed again. No for sure I don't force push anything, not that confident in here yet. :-)

tanberry avatar Apr 16 '21 16:04 tanberry

Ah, I just saw in the Jira the new/updated code chunk. OK, will add that in next.

tanberry avatar Apr 16 '21 18:04 tanberry

hey @darinspivey, i changed it last minute on Tana and caused some confusion 🤦. What's in the Jira now has the correct modifications. Changed ordering, comments, a little structure and added a warn example

braxtonj avatar Apr 16 '21 18:04 braxtonj

okeeeee now this PR has the latest code block, the whole thing, in it, and is ready for review/approval/merging. ;-)

tanberry avatar Apr 16 '21 18:04 tanberry