logdna-winston icon indicating copy to clipboard operation
logdna-winston copied to clipboard

Published 20 hours ago • verified publisher icon logdna

Create type definition

Open Sytten opened this issue 4 years ago • 8 comments

Fixes https://github.com/logdna/logdna-winston/issues/18

Sytten avatar May 06 '20 01:05 Sytten

@smusali if you have time to review

Sytten avatar May 06 '20 01:05 Sytten

Just a little ping to get some feedback, thanks!

Sytten avatar May 18 '20 13:05 Sytten

Another ping just to make sure I am not forgotten @smusali @jakedipity

Sytten avatar May 24 '20 20:05 Sytten

@smusali Let me know if you prefer that I copy the props from the parent, otherwsie feel free to merge.

Sytten avatar May 25 '20 21:05 Sytten

Dear @smusali, I hope you will the changes to you liking. Please see my comment above concerning a potential bug with defaults. I am also starting to consider that maybe the options interface should not inherit from the parents since it's particular mix of both (the case of level is problematic for example).

Sytten avatar Jun 06 '20 23:06 Sytten

Dear @smusali, I hope you will the changes to you liking. Please see my comment above concerning a potential bug with defaults. I am also starting to consider that maybe the options interface should not inherit from the parents since it's particular mix of both (the case of level is problematic for example).

That's fine! I'll have a couple of requests as well

smusali avatar Jun 10 '20 15:06 smusali

@smusali I think it would be best if you take over, I do not have the bandwidth to go back and forth over this issue anymore. Thanks!

Sytten avatar Jul 06 '20 17:07 Sytten

@smusali can you please merge this?

TrejGun avatar Jul 28 '21 04:07 TrejGun