vee-validate
vee-validate copied to clipboard
fix: mark form dirty when object keys are deleted
🔎 Overview
This PR fixes an issue where removed keys of objects in field values don't mark the form as dirty, because the isEqual
method is not commutative. Please refer to this comment for a demonstration of the issue: https://github.com/logaretm/vee-validate/issues/4678#issuecomment-2015075349.
I read that a changeset was desired when submitting a PR, but I'm unsure what to include. Please advise.
✔ Issues affected
closes #4678
(Also credits to @SCBosch)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.90%. Comparing base (
2a0881f
) to head (b83365b
).
Additional details and impacted files
@@ Coverage Diff @@
## main #4710 +/- ##
==========================================
+ Coverage 89.87% 89.90% +0.02%
==========================================
Files 93 93
Lines 7676 7695 +19
Branches 1360 1367 +7
==========================================
+ Hits 6899 6918 +19
Misses 770 770
Partials 7 7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.