vee-validate icon indicating copy to clipboard operation
vee-validate copied to clipboard

Field groups

Open zaalbarxx opened this issue 1 year ago • 9 comments

🔎 Overview As detailed in #4181, it is extended version of PR #4553. This one, besides of exposing additional fields also adds new FieldGroup component with tests and documentation (documentation could not be verified since on my machine the documentation throws some errors image

🤓 Code snippets/examples (if applicable) https://stackblitz.com/edit/vue-3-veevalidate-form-validation-example-1dlyi1?file=src%2Fvee-validate.esm.js,src%2Fmain.js,package.json,src%2FApp.vue

Here is the code snippet with vee-validate.esm.js built from the branch which shows how it actually works.

Issues affected closes #4181

Also for some reason the builds are failing, I could get some assist here. But first of all, and most important question is if we will process with this PR ? :)

zaalbarxx avatar Nov 21 '23 13:11 zaalbarxx

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a50956c) 89.81% compared to head (03c3601) 89.99%.

Files Patch % Lines
packages/vee-validate/src/useFieldGroup.ts 92.22% 7 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4554      +/-   ##
==========================================
+ Coverage   89.81%   89.99%   +0.17%     
==========================================
  Files          93       95       +2     
  Lines        7651     7855     +204     
  Branches     1345     1367      +22     
==========================================
+ Hits         6872     7069     +197     
- Misses        772      779       +7     
  Partials        7        7              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 21 '23 13:11 codecov[bot]

After reverting docs package.json to state before recent version bumps I was able to run the documentation locally. Made some changes and labeled the FieldGroup component as v4.7.

zaalbarxx avatar Nov 21 '23 14:11 zaalbarxx

Also downgraded remark-gfm to 3.x since I found that it's the culprit of failing docs build.

zaalbarxx avatar Nov 21 '23 14:11 zaalbarxx

@logaretm Extended the functionality by adding useFieldGroup composable. Could also come handy. Cheers.

zaalbarxx avatar Nov 22 '23 09:11 zaalbarxx

Thanks, I will take a look when I can (around the weekend)

logaretm avatar Nov 23 '23 22:11 logaretm

Any update on this ? Is it possible it will make it into the package ? Not sure if I should take my time to resolve conflicts and stuff :)

zaalbarxx avatar Dec 18 '23 11:12 zaalbarxx

Hey @zaalbarxx, Unfortunately I have not had the time to check this out yet. This is a significant feature work and I would like to make sure we aggressively scope how this feature works because it caused problems before in the past:

So give me sometime to think about this some more, and sorry about the delay, I appreciate the time you've put into this.

logaretm avatar Dec 19 '23 22:12 logaretm

Any news on this? We would like to use groups too 🤞🏻

YoshiYo avatar Feb 21 '24 11:02 YoshiYo

It does work on production for us, for over 3 months, if that matters anyhow. If you'd like to use it too @YoshiYo I released "patched" packages at

"@zaalbarxx/vee-validate": "4.12.3",
"@zaalbarxx/vee-validate-i18n": "4.12.3",
"@zaalbarxx/vee-validate-rules": "4.12.3",

I had to release all of the packages since they depend on each other (like rules depend on validate), so patched versions also have their dependencies changed. The con is that you'd have to change all references in imports from vee-validate to @zaalbarxx/vee-validate, so that's propably a bit of an overkill. Anyway, it works for us and I'm also waiting for it to go through.

zaalbarxx avatar Feb 21 '24 11:02 zaalbarxx