streamroller icon indicating copy to clipboard operation
streamroller copied to clipboard

add _writev again for batch write logs

Open yss opened this issue 5 years ago • 1 comments

It is better to add _writev function for batch write logs.

The most important point is the performance that improve the speed of log.

but also there will cause some unexpected results, like

  1. the size of log file may bigger that the maxSize when set maxSize config.
  2. may cause more memory usage.

Also, I saw the deleted pull request at https://github.com/log4js-node/streamroller/pull/25. And I fixed the failed test cases.

yss avatar Dec 30 '19 14:12 yss

Hi, thanks for this. I totally agree that _writev should be implemented, but the travis CI build is failing because there are no tests which use this code. How do you know that it works? Have you done some performance tests so see if this improves things? Looking at the code, I can't see that this will make much difference to memory usage or performance - but maybe I am missing something.

nomiddlename avatar Jan 06 '20 21:01 nomiddlename