vcluster icon indicating copy to clipboard operation
vcluster copied to clipboard

restore vCluster config from snapshot

Open neogopher opened this issue 2 months ago • 2 comments

What issue type does this pull request address? (keep at least one, remove the others) /kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) resolves ENG-9486

Please provide a short message that should be published in the vcluster release notes vCluster will now automatically restore the cluster.yaml configuration while restoring from a snapshot

What else do we need to know?


[!NOTE] Load Helm release values from snapshot, merge with defaults, use for restore/config parsing, and write to vc-config-* Secret; CLI consumes snapshot values/versions during --restore.

  • Restore pipeline:
    • Add snapshot.GetVClusterReleaseFromSnapshot to extract HelmRelease from snapshot.
    • Merge release values with defaults (mergeWithDefaults) and parse config via config.ParseConfigBytes.
    • Initialize clients (InitClients) and use merged config for restore validation.
    • Persist merged values to Secret vc-config-<name> (config.yaml).
    • Refactor createRestoreRequest to use internal o.vConfig.
  • CLI (pkg/cli/create_helm.go):
    • Use snapshot.GetVClusterReleaseFromSnapshot to fetch config on --restore.
    • Auto-set cmd.ChartVersion from snapshot release and temp-write values for install/upgrade.

Written by Cursor Bugbot for commit 4d888da6cf4fd10778383162001d147b8f1f23e7. This will update automatically on new commits. Configure here.

neogopher avatar Nov 04 '25 11:11 neogopher

@claude Please review this PR and suggest improvements

pascalbreuninger avatar Nov 10 '25 06:11 pascalbreuninger

bugbot run

pascalbreuninger avatar Nov 10 '25 06:11 pascalbreuninger