loft-sh
SyncLabels missing from Helm chart schema
What happened?
I've been using the OSS vCluster v0.20.0 for a while, realised it's EOL so want to upgrade to 0.24.0 stable.
I'm having an issue deploying the vCluster Helm chart due to experimental.syncSettings.syncLabels not being defined in the v0.24.0 chart's schema and my use case requires it.
I believe helm itself has recently gained support to skip schema validation but I cannot use the helm cli directly. I'm using Crossplane's helm provider to deploy the chart and unfortunately it doesn't surface the new helm cli feature yet (I raised an issue there).
What did you expect to happen?
The docs for v0.24 suggest syncLabels is still supported so expected the chart schema.json to include it. Whilst it existed in v0.20 schema, it looks to have been removed from v0.21 onwards.
I expect if the docs say it is supported and it truly is, then the schema should include it. If it's not supported, suggest an alternative way of achieving the same functionality (if possible).
How can we reproduce it (as minimally and precisely as possible)?
Provide a string value for experimental.syncSettings.syncLabels in a values.yaml file and attempt to deploy the loft/vcluster chart v0.24.0.
Anything else we need to know?
No response
Host cluster Kubernetes version
Client Version: v1.29.1
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.0
vcluster version
vcluster version 0.24.0
VCluster Config
Not available
Some slack advice advised me that all labels are automatically synced from v0.21.x onwards, and I've just tested with v0.24.0 and my cluster's pods still work as they did with v0.20.0. This is good but could this perhaps be documented please?
That is correct, since v0.21 this config option is no longer needed. I removed last syncLabels documentation reference I could find.
could this perhaps be documented please? IMO this is borderline implementation detail, so not sure if it must be documented. How are you using the labels in the host? Would you be willing to contribute a PR with the documentation?
