vcluster icon indicating copy to clipboard operation
vcluster copied to clipboard

fix(setup): improve timeout handling for certificate generation

Open mayooot opened this issue 9 months ago • 1 comments

What issue type does this pull request address?

/kind feature

What does this pull request do? Which issues does it resolve? https://github.com/loft-sh/vcluster/issues/2591

Please provide a short message that should be published in the vcluster release notes

  • Increase overall timeout in Initialize function from 2 to 5 minutes
  • Add 30-second timeout contexts for initialize

mayooot avatar Mar 14 '25 11:03 mayooot

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
Latest commit fa72b2d2078252c0f6e2bdcc0615807500a4c61e
Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/67d4150db2346c0008c9da6f

netlify[bot] avatar Mar 14 '25 11:03 netlify[bot]

@zerbitx @FabianKramm Could you please review this?

mayooot avatar Aug 18 '25 08:08 mayooot

@mayooot Thanks for the contribution! Some recent changes have removed the polling and gone with a strategy of allowing it to fail on the first error, rather than polling. The timeouts shouldn't be needed anymore. I'm going to close this PR and the issue, but please reopen and tag me if you find it still not working as you would expect.

zerbitx avatar Sep 04 '25 17:09 zerbitx