vcluster icon indicating copy to clipboard operation
vcluster copied to clipboard

Adds min and max to LimitRange

Open emoreth opened this issue 1 year ago • 4 comments
trafficstars

What issue type does this pull request address? (keep at least one, remove the others) /kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) The LimitRange resource lacks options for min and max.

Please provide a short message that should be published in the vcluster release notes Add min and max options to LimitRange

What else do we need to know?

emoreth avatar Aug 21 '24 21:08 emoreth

Deploy Preview for vcluster-docs canceled.

Name Link
Latest commit ae288956b927ffb54f4a243fd490b29cb3a72005
Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/6703a228d0c75d0008a0ec6c

netlify[bot] avatar Aug 21 '24 21:08 netlify[bot]

@emoreth thanks for creating this PR! With the current implementation this won't have any effect, are you sure this PR is complete since there are no chart changes.

FabianKramm avatar Aug 22 '24 08:08 FabianKramm

Sorry, I missed pushing a file 🤦

emoreth avatar Aug 22 '24 14:08 emoreth

@emoreth thanks for that, you will also need to add that to the config.go and then generate the schema via go run hack/schema/main.go as described in https://github.com/loft-sh/vcluster/tree/main/config . Then I can merge it

FabianKramm avatar Aug 23 '24 07:08 FabianKramm

@FabianKramm Sorry for the @, but this should be a quick one

emoreth avatar Sep 30 '24 11:09 emoreth