vcluster icon indicating copy to clipboard operation
vcluster copied to clipboard

run tests on all commits for main

Open facchettos opened this issue 9 months ago • 5 comments

What issue type does this pull request address? (keep at least one, remove the others) /kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) resolves #

Please provide a short message that should be published in the vcluster release notes Fixed an issue where vcluster ...

What else do we need to know?

facchettos avatar Apr 29 '24 13:04 facchettos

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
Latest commit ec773ee63bf182bb5332d14f76e7032f88d8003b
Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/662fa1bf6fae530008955ded

netlify[bot] avatar Apr 29 '24 13:04 netlify[bot]

@facchettos why do we need this?

FabianKramm avatar Apr 30 '24 08:04 FabianKramm

@FabianKramm because we don't use either a merge queue or ensure that the pr branch is up to date with main, so there is some possibility that main breaks because of changes that don't conflict in git but do in the logic

facchettos avatar Apr 30 '24 08:04 facchettos

Then we should enforce that the PR branch is up to date with main, because nobody is looking at the tests after merge and they just count towards our minute limit

FabianKramm avatar Apr 30 '24 09:04 FabianKramm

enforcing the pr's head to be up to date will actually be more expensive than running the tests on main, because all PRs will need a new ci run after each merge to main before they can be merged

facchettos avatar Apr 30 '24 09:04 facchettos