Matěj Štágl

Results 163 comments of Matěj Štágl

@scgm0 thanks @lahma could you have another look at this please? The 90 tests would need to be skipped.

I wonder whether we wait for Acornima with this one, as it should provide the information we need from the quick look I took - https://github.com/adams85/acornima

> > I wonder whether we wait for Acornima with this one, as it should provide the information we need from the quick look I took - https://github.com/adams85/acornima > >...

A minimal reproducible issue: ```cs [Fact] public void ShouldPromiseBeResolved() { var log = new List(); Engine engine = new(); engine.SetValue("log", (string str) => { log.Add(str); }); var result = engine.Execute("""...

Can confirm the behavior is still the same as of 3.0

> If there's a solid use case for such configuration, why not. We've discussed this over at Acornima https://github.com/adams85/acornima/issues/6 This was previously requested here as well: https://github.com/sebastienros/jint/issues/490 This should warrant...

@scgm0 the PR is missing XML doc for the newly added public members, if you want I can add that for you. Also thanks for implementing this, much appreciated.

@scgm0 I've opened a PR against your branch with the docs. Getting win/fw462 to pass the tests requires resigning the Tests assembly due to the added dependency on `SourceMaps` I...

@cristipufu is there something blocking the merge here? We'd like to use this and stay in sync with upstream.

Fixed and Sliding window in our case @cristipufu