locust icon indicating copy to clipboard operation
locust copied to clipboard

Remove legacy UI

Open andrewbaldwin44 opened this issue 9 months ago • 2 comments

  • Remove words "legacy" and "modern" from codebase as we only have one UI now
  • Remove legacy-ui and modern_ui flags
  • Remove logic for rendering legacy UI
  • Remove templates and static assets for legacy UI
  • Update UI tests to suit the modern UI
  • Update documentation to only include logic for modern UI
  • Ensured modern UI, web login, HTML report, and downloaded HTML report all continue to work as expected

andrewbaldwin44 avatar May 06 '24 00:05 andrewbaldwin44

Nice!

Can we keep the argument around (and hide it using help=configargparse.SUPPRESS), and exit with an error message if someone sets it?

cyberw avatar May 06 '24 06:05 cyberw

LGTM. Especially if you add help=configargparse.SUPPRESS in argument_parser.py :)

I'll want to hold off a day or two on merging though, because I'd like to release the changes already merged as a separate release.

cyberw avatar May 06 '24 14:05 cyberw

Nice!

cyberw avatar May 07 '24 07:05 cyberw