locustio
Use `random.choices` when selecting a task instead of `random.choice`
Prerequisites
- [X] I am using the latest version of Locust
- [X] I am suggesting a new feature, not asking a question
Description
According to current implementation/documentation, if weights are given to tasks, tasks are stored in the list duplicated by the amount given as weight, and then the task is selected from the list by using Python's random.choice.
This, however, has two shortcomings:
- Inserting big weights can lead to unreasonably big datastructures
- Only integers can be weights
It should be fairly easy to rewrite the gen_tasks_from_base_classes function and how it's output is handled in TaskSet class to store the weights separately and pass them together with the list of tasks to random.choices in gen_next_task.
This will allow to store arbitrarily large weights without duplicating tasks in integer or float as well as potentially enable the functionality to modify task weights at runtime by modifying the list storing the weights.
I could try to implement this with a PR if this change is desired.
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@cyberw Yes I actually finally got around to working on this two days ago! I think I already changed the list to the dict in the class itself, now I need to figure out which external things are affected, like helper functions and tests.
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.
This issue was closed because it has been stalled for 10 days with no activity. This does not necessarily mean that the issue is bad, but it most likely means that nobody is willing to take the time to fix it. If you have found Locust useful, then consider contributing a fix yourself!