loco-odoo

Results 24 comments of loco-odoo

> If it has to wait for something before being merged, so be it. @qsm-odoo , now that [this commit](https://github.com/odoo/odoo/commit/94b55d913b179b033bfc74f8fb1545675c75db9b) has been merged, this PR has everything it needs to...

Closed as it will be done in https://github.com/odoo/odoo/pull/155575

Note: Adapt the version 17.0 and more specifically [this commit](https://github.com/odoo/odoo/commit/290d6ac1baef363dce1e39ead708f303ce599fcc)

> Actually, the use of .o_modified_image_to_save will force the creation of a new attachment for technically the same image every time we cancel the crop. @xO-Tx Indeed, we could try...

Thanks for the fix @bvr-odoo ! It looks good to me. I also tried your fix in master and it solves the bug that damien (deda) reported (modification of pricelist...

> Just wondering, what's the plan for upgrade ? Clean up all those attribues from existing XML/HTML and generate the related options records ? Exactly, that is the idea :+1:

Idea for future improvements (after this PR is merged): - A refactoring could add the `o_modified_image_to_save` class on the image directly in the `_loadImage()` method (if the argument `imgEl` is...

Thanks for the changes @bso-odoo ! :pray: @robodoo r+

@qsm-odoo , this opw fix is ready for your review :+1:

@xO-Tx , just to be sure that you still have this one in mind :+1: