udig-platform get collapse vertices setting from preference store

Adds the possibility to change the collapse vertices setting in EditBlackboard programmatically via the preference store.

Signed-off-by: sloob [email protected]

Oct 10 '18 12:10 sloob

Hi @sloob, Is there a particular reason that the specified property was not included in EditToolPreferences class so that it is available for direct editing in the edit property page UI (similar to what you propose in #314 and #313)?

Oct 22 '18 08:10 nprigour

Hi @nprigour,

the problem is that the preference is set in the constructor of the EditBlackboard. If the setting is changed, the existing EditBlackboards do not get that. I also found no way to query all EditBlackboards and set the new preference via the method EditBlackboard#setCollapseVertices(boolean). Programmatically, the preferences are typically set only once when the application is started, so i guess, the problem described above is not critical here. If the setting should also be changed via the UI, i suggest the following: With this setting, it should be indicated on the PreferencePage that the change is only active after a restart of the application. Should i implement the EditToolPreferences in this way or do you have another suggestion?

Oct 23 '18 07:10 sloob

Hi @sloob No no need to change anything in your PR. I was just curious because it was not obvious to me why the properties in #314 and #313 were exposed to the UI and this one not. Your clarification is sufficient.

Oct 23 '18 09:10 nprigour

Would please update user-documentation as well that describes what happens on any change of this preference value? In addition due to other changes in this area the current changest has conflict that mus be resolved.

Sep 18 '19 21:09 fgdrf