spatial4j icon indicating copy to clipboard operation
spatial4j copied to clipboard

Published 20 hours ago • verified publisher icon locationtech

Drop ParseUtils

Open chrismale opened this issue 13 years ago • 4 comments
trafficstars

This is extremely complex code just to parse latitude, longitude. We should simplify it and put it where it belongs (if we even have a need for it).

chrismale avatar Sep 25 '12 07:09 chrismale

I think we have a need for the underlying functionality, at least some of the methods therein. Where do you propose it "belongs"?

dsmiley avatar Sep 25 '12 14:09 dsmiley

The underlying functionality is parsing a comma-separated list of doubles and doing some validation. It's only used in the dubious ShapeReadWriter.readLatCommaLonPoint. We can hugely simplify the functionality there so it quickly parses the two doubles.

I don't see the need for generic 'multi-dimensional' point parsing in Spatial4j today.

chrismale avatar Sep 25 '12 23:09 chrismale

I agree; I'm going to mark this as deprecated for 0.4 and remove in a subsequent release. I'll move the code in question to perhaps a utility class in Lucene-spatial or Solr.

dsmiley avatar Jan 15 '14 04:01 dsmiley

+1

chrismale avatar Jan 15 '14 05:01 chrismale