ShapeReader.read(String)

[dsmiley]

I think ShapeReader.read(String) should exist, and furthermore should not throw IOException. Contrast this to the existing read(Object) defined now which does throw IOException and every implementation converts it to a String. I propose both read(Object) and readIfSupported(Object) be changed to be String based and to not throw IOException. read(Reader) is debatable... I wonder if it's worthwhile to bother.

@jdeolive @ryantxu what do you think?

[jdeolive]

Those changes make sense to me, agree not much sense in making users handle the IOException when no implementations actually do any real IO. +1

[ryantxu]

+1 to change read(Object ) to read(String ) and drop the IOException

I'm not sure about the read(Reader) option -- i like it, but i can see why it may be more complex than typically needed

ryan

On Wed, Jan 6, 2016 at 12:10 PM, Justin Deoliveira <[email protected]

wrote:

Those changes make sense to me, agree not much sense in making users handle the IOException when no implementations actually do any real IO. +1

— Reply to this email directly or view it on GitHub https://github.com/locationtech/spatial4j/issues/129#issuecomment-169444440 .