rasterframes icon indicating copy to clipboard operation
rasterframes copied to clipboard

Documentation Results Issues

Open metasim opened this issue 5 years ago • 6 comments

Refer to this build: https://3415-174014757-gh.circle-artifacts.com/0/rf-site/index.html

  • In unsupervised-learning.pymd the final prediction raster is a single color: image

  • In masking.pymd the masks from SCL aren't rendered properly as tiles. However, application of mask looks correct: image

  • In raster-join.pymd need to confirm the MODIS columns is correct.... looks like multiple resolutions are being combined? image

metasim avatar Oct 27 '20 14:10 metasim

https://github.com/locationtech/rasterframes/pull/516

vpipkt avatar Oct 27 '20 18:10 vpipkt

this first one (unsupervised) seems similar to #511 .. not real sure but maybe

Can confirm the unsupervised is only happening in the branch not on develop.

vpipkt avatar Oct 27 '20 18:10 vpipkt

About raster join: i suspect this is an artefact of using cubic convolution near areas of NODATA. FWIW this is not specific to the branch. THe current develop branch nighly build is showing the same. Link. Screenshot:

image

Compare to nearest neighbor (in prod docs). Note the regions of NODATA ...

image

vpipkt avatar Oct 27 '20 18:10 vpipkt

Unsupervised learning: can collect the incorrectly displaying dataframe / row/ Tile to the driver, and it shows up nicely with the PNG repr... hopefully that is an important clue

vpipkt avatar Oct 27 '20 18:10 vpipkt

another intersting thing about that is the celltype of the rf_agg_overview_raster is int32, for the rf_agg_overview_raster but the retiled.prediction column is int8.

A further note here is that just a table view of retiled also shows a completely purple / 0 tile in the table preview

vpipkt avatar Oct 27 '20 19:10 vpipkt

In unsupervised, retiled.select(rf_convert_cell_type('prediction', 'float32')) shows us what we expect....

possibly something to do with the way histograms are computed here https://github.com/locationtech/geotrellis/blob/bb5f8642bd0ae04913e1742d65d86e095500486d/raster/src/main/scala/geotrellis/raster/render/PngRenderMethods.scala#L52-L61

vpipkt avatar Oct 27 '20 19:10 vpipkt