Remove geofield_map as a require-dev

[finnlewis]

See https://github.com/localgovdrupal/localgov/blob/3.x/composer.json#L52

We removed the dependency in https://github.com/localgovdrupal/localgov_geo/releases/tag/2.0.1

So we should be able to remove from require-dev.

[andybroomfield]

Isn't this used by localgov_paragraphs? I think the contact paragraph still uses it?

[millnut]

This is the cause of this error https://github.com/localgovdrupal/localgov/issues/915 due to the old database used for upgrades needing it

[finnlewis]

But it looks like we've not removed it yet https://github.com/localgovdrupal/localgov/blob/3.x/composer.json#L52

[millnut]

Correct but the failed pipeline that ran at drupal.org in https://github.com/localgovdrupal/localgov/issues/915 does have it removed as part of the commit https://git.drupalcode.org/project/localgov/-/commit/972de037a70dfb716c7ffe6e92e5455fdf45f3e0

[andybroomfield]

How far back do we need to test upgrade tests, as we're going to need to keep a lot of dependencies. Aside from making an LGD version of the chain of fools video I think we should drop support for upgrades from super old versions (+1 or +2 years old) and streamline the update_hooks maybe. That should then allow us to remove the geofield_map dependency.

Note: BHCC does still use it, but we added this to our root composer.json so we can use the widget. Others would have had to do the same as this is require-dev only.

[millnut]

That's a good question @andybroomfield I believe it tests the upgrade of the profile 2.x to 3.x. I don't believe 2.x of the profile is supported now, so do we still need an upgrade test from an unsupported version?