localgov icon indicating copy to clipboard operation
localgov copied to clipboard

Drupal 11 patch failure: Users can't reference unpublished content even when they have access to it

Open stephen-cox opened this issue 6 months ago • 4 comments

Patch 87 from https://www.drupal.org/project/drupal/issues/2845144 fails to apply with Drupal 11.

stephen-cox avatar Jun 20 '25 09:06 stephen-cox

This is going to be a bit of an issue - there different patches for Drupal 10 and 11 and it's not possible to target different versions with different patches: https://github.com/cweagans/composer-patches/issues/130

As this is breaking test runs, I'm going to ignore this patch in the 3.2.x profile, but we need a fix for this before a stable version of D11 is released.

stephen-cox avatar Jun 27 '25 14:06 stephen-cox

Temporary fix: https://github.com/localgovdrupal/localgov_project/pull/214/files

stephen-cox avatar Jun 27 '25 14:06 stephen-cox

I wonder whether we need to discuss again on have 3.x for D10 and re-introduce 4.x for D11?

millnut avatar Aug 16 '25 12:08 millnut

I wonder whether we need to discuss again on have 3.x for D10 and re-introduce 4.x for D11?

Yep - I think we're going to need a major version to handle this. cweagans/composer-patches does not have the ability to target different patches to different versions. We could change to vaimo/composer-patches, but this would be a big change as we use cweagans/composer-patches all over the place.

I'm going to create/update the necessary 4.x branches and see if I can get everything working there. They can always be removed if we go with a different approach.

stephen-cox avatar Sep 23 '25 10:09 stephen-cox