localgov icon indicating copy to clipboard operation
localgov copied to clipboard

Can we remove geofield_map?

Open millnut opened this issue 11 months ago • 2 comments

Searching the repo I cannot see it used but it's declared as a dev dependency of localgov

millnut avatar Jan 01 '25 15:01 millnut

@millnut It was added to resolve an issue with the update test as the original versions of localgov_geo used geofield_map in configuration. See https://github.com/localgovdrupal/localgov/pull/637#issuecomment-1798301161

Though there is a comment on that about a replacement update test so if that has been removed, so can the dev dependency.

andybroomfield avatar Jan 04 '25 14:01 andybroomfield

Be nice not to have to maintain that update for much longer either tbh. It's quite the update. So maybe we could move to dev now, and gone in 'a short while' (bumping localgov geo a minor and removing that update too).

If there's anyone who hasn't updated yet it's probably heading to problematic. And if they haven't they'd have to 1.x 2.0 2.1 which isn't the end of the world.

ekes avatar Jan 21 '25 14:01 ekes