localgov icon indicating copy to clipboard operation
localgov copied to clipboard

Fix scrolling issues in editor

Open willguv opened this issue 1 year ago • 6 comments

Mentioned at LocalGov Drupal Camp by @benhillsjones (?) and others, there are occasional issues when scrolling up and down pages

Let's walk through this and discuss possible improvements

willguv avatar May 08 '24 08:05 willguv

We have this issue on localgovdrupal.org and asked @stephen-cox to take a look. He deployed a fix which seems to be working so maybe a quick win? It's very annoying for content editors as it makes editing pages with long paragraphs very difficult - the work around is zooming out to 33% to enable you to see and hit the save button.

aaronhirtenstein avatar May 08 '24 11:05 aaronhirtenstein

There's an issue on drupal.org for this here: https://www.drupal.org/project/layout_paragraphs/issues/3417765

The fix I implemented is here: https://github.com/localgovdrupal/localgovdrupal.org/commit/c06600630572038a17f2a7e3c1944ab695142d90

I didn't upload the patch to Github as it needs discussion as it takes a very different approach to the other patches on the site.

If this of use to others I can discuss with the best way to fix with with the technical people here.

stephen-cox avatar May 08 '24 13:05 stephen-cox

Cheers @stephen-cox and @justinepocock metioned the modal settings: https://www.blackburn.gov.uk/admin/config/content/layout_paragraphs/modal-settings You want the settings on that page to look like this image

aaronhirtenstein avatar May 10 '24 10:05 aaronhirtenstein

see this Slack thread for video example of the issue: https://localgovdrupal.slack.com/archives/C020SJRQX2M/p1715257361142789

aaronhirtenstein avatar May 10 '24 10:05 aaronhirtenstein

The setting @justinepocock mentions looks to fix the issue with the action buttons disappearing off the bottom of the screen in a modal popup. Interestingly, this seems to be set with new installs. I don't think we changed this so something changed in Layout Paragraphs to set this by default.

The issue in the video is a different issue and already reported here https://github.com/localgovdrupal/localgov/issues/664

stephen-cox avatar May 14 '24 10:05 stephen-cox

Can we assume this issue is closable / resolved? I no longer encounter scrolling issues when editing on BHCC site and I see the above modal issues in the layout paragraphs modal editor.

andybroomfield avatar Dec 24 '24 12:12 andybroomfield