Do we still need bootstrap classes?

[keelanfh]

We still have quite a few bootstrap classes dotted about the distribution.

Just came up as an issue for me this morning as we had some analytics tags that were supposed to be tracking the start button but weren't, because someone had assumed that all instances of the start buttons had the same bootstrap classes, but some of ours didn't (depending on how they were set up).

At the very least, perhaps we could remove them from the default wysiwyg profiles - which would only affect new sites. I'd expect that most new sites are either subtheming localgov_base or creating their own theme which may or may not use Bootstrap - in any case, if they're going down that route, they'll probably make their own changes to these.

What do you think?

[keelanfh]

Related issues: https://github.com/localgovdrupal/localgov_eu_cookie_compliance/issues/2 https://github.com/localgovdrupal/localgov_guides/issues/85

Some instances of bootstrap classes: https://github.com/search?q=org%3Alocalgovdrupal+%22+col-%22+-repo%3Alocalgovdrupal%2Flocalgov_theme_croydon+-repo%3Alocalgovdrupal%2Flocalgov_theme+-repo%3Alocalgovdrupal%2Flocalgov_base_croydon&type=code

@markconroy

[markconroy]

They might be needed for legacy reasons in some of the modules, and were actively introduced in the localgov_eu_cookie_compliance module recently. We should look at removing them from modules if at all possible, and have them all written using BEM naming style, like we do in localgov_base.

There are none in localgov_base - no dependencies on external code was one of the principles in the rewrite of the localgov_base theme.

I'd like to see them removed from the wysiwyg profile too, but not sure exactly how we'd achieve that.

[keelanfh]

It would be fairly easy to remove these from the wysiwyg profile for new installs, and that wouldn't have any impact on existing installs. I think that would be the safest option and I'd be in favour of that.

[keelanfh]

I have an open PR for some changes to the wysiwyg config which I will update to include this.

[andybroomfield]

Check to see if any are still present.