localgovdrupal
Shared fields: email, phone, twitter, facebook
Hopefully this one is more of a straightforward one. field_email_address presently on: Service landing page, Local offer, Directory entry.
It would seem fair that the same field is used by everything that wants an email address. Can't see that data would actually be used cross-site, but equally no reason not to have just one.
@willcallaghan @andybroomfield Only if you remember something about email usage. Otherwise I'm assuming share.
Expanding this one as they're all similar:
- field_facebook | attached to: Service landing page, Directory entry | comments: Is it used? It's just a plain text field rather than a link field (core) or anything more clever.
- field_twitter | attached to: Service landing page, Directory | comments: used just a bit more? Also just a plain text field rather than anything clever.
- field_phone | atached to: Service landing page, Local offer, Directory entry | comments: This is used. It's a text field. There's a phone field in drupal core! Some content includes description ' Croydon CAMHS Telephone:' but shouldn't it be a validated phone number that's marked up so when you click your phone will know it's a number.
(there is also a non-shared field_hearing_difficulties_phone field - no need to decide where this goes, but if phone fields are standardized this is a reminder to include it).
A lot of these are pre my times at BHCC. Possible makes sense to seperate out storage. Croydon also has the new reusuable fields block using paragraphs, not sure if these are something they have within it @lbcwebmaster ?
Just checking and these fields are only used on service landing pages now, and directories uses their own fields / paragraphs. So actully this is redundant, however I do think we should move these fields from localgov_core and into localgov_services_landing module instead. Would doing this have any effect on existing sites? They already have the (renamed) config installed so this would only be new sites that would need the localgov_services module installed and enabled, which they should do anyway.
Suggest we consider this for Localgov 3, I think we can remove the fields from core and add them to services. I think a few people are moving in favour of contact card, but the pattern is still in place. Might even be worth thinking through a way to upgrade them if present?
Possible a bit late, but I'll raise the issue in localgov_core. These fields where originally shared between the services and directories content types, hence why they ended up in localgov_core. However... Directories now use their own fields (localgov_directories_email etc) so it's only the services pages that use them... I guess some sites could have then used them on other content types, but an update won't delete them, its just sorting them in the right place. I think many sites are defaulting to a contact card type paragraph so these fields may become redundant in the future.