lobsters icon indicating copy to clipboard operation
lobsters copied to clipboard

Move Send Webmentions to ActiveJob

Open vivshaw opened this issue 10 months ago • 3 comments

This PR does the next chunk of #1548, and the first which is an async enqueued job vs. a timed cron job. There were some larger changes in this one. I'll notate them in self-review.

vivshaw avatar Jun 17 '25 04:06 vivshaw

I had a minute and wanted to toss in a couple notes.

BTW, your work moving Mastodon to a job is paying off; because those are properly wired into our exception tracking (where cron errors were yeeted into the outer darkness), I caught and fixed a lurking bug. Thanks again!

pushcx avatar Jun 17 '25 13:06 pushcx

OK, after a few false starts I think we're now in a good spot. This works to the fullest extent I can test without a staging env, i.e., it can run the job without blowing up, targeting a real site with webmentions, and said job fires the POST that I would expect to the place I would expect. (I can't be 100% because actually confirming that the webmention sticks would require a public URL to the page that's hosting the mention)

vivshaw avatar Jun 18 '25 06:06 vivshaw

This PR has had no activity for 21 days. Please leave a comment or commit to indicate you're still actively working on it.

github-actions[bot] avatar Aug 24 '25 10:08 github-actions[bot]

I think the stalebot is catching my mistake, that I've let this slip through the cracks. @vivshaw is this ready to review for merge? From skimming the conversation it sure looks complete, and I'm sorry if I've accidentally left it to go stale.

pushcx avatar Aug 25 '25 21:08 pushcx

This PR has had no activity for 21 days. Please leave a comment or commit to indicate you're still actively working on it.

github-actions[bot] avatar Sep 17 '25 10:09 github-actions[bot]

@pushcx well hey, I also let it slip through the cracks. was outta town for a while, was Planning Season at work for a while, and completely forgot I had never followed up with this. such is life!

I just merged in master and tested it locally once again. far as I'm aware, this is indeed ready for review!

vivshaw avatar Sep 18 '25 03:09 vivshaw

Just did another review, there's only two small changes before this is ready to go. Again, I'm sorry I let this hang out so long, thanks for continuing to work on it.

  1. Add the enqueue_after_transaction_commit = true linked in the 'testing' thread. Which... I think should go up in ApplicationJob. It seems like it protects us from a footgun and we should be leaving a comment in each job that wants to opt out of it.
  2. Add the return if dev check from the same thread.

pushcx avatar Oct 04 '25 20:10 pushcx

This PR has had no activity for 30 days. Please leave a comment or commit to indicate you're still actively working on it.

github-actions[bot] avatar Nov 04 '25 10:11 github-actions[bot]

I didn't want this to wait around, so I made those last couple tweaks in the merge commit.

Thanks for implementing this!

pushcx avatar Nov 10 '25 20:11 pushcx