lobsters icon indicating copy to clipboard operation
lobsters copied to clipboard

Add database_consistency and database_validations gems

Open pushcx opened this issue 1 year ago • 5 comments

https://github.com/djezzzl/database_consistency

https://github.com/toptal/database_validations

Lobsters would benefit from the improved performance + data quality provided by these gems.

These each could be a significant amount of work. It’s OK to work through their addition in several PRs if you prefer.

pushcx avatar May 29 '24 15:05 pushcx

I have experience with database_consistency and a bunch of other similar tools. I can start knocking some of these off. One question; is lobsters OK with foreign key constraints? I know some teams prefer not to use them.

hmaddocks avatar Jun 05 '24 20:06 hmaddocks

That would be great, thank you for volunteering.

Lobsters uses FKs now and I'm happy to continue that. (Speaking of schema.db, I do slightly prefer using schema.sql but there's never been a reason to touch it; you can swap if it offers value to this project.)

pushcx avatar Jun 05 '24 20:06 pushcx

@pushcx Looks like the PR above is already merged. May we close this issue?

(Yeah, I still looking for good first issues :D)

petrenkorf avatar Sep 19 '24 17:09 petrenkorf

There are still some improvements to make. I have a local branch with some of them but I got really busy sorry.

hmaddocks avatar Sep 19 '24 19:09 hmaddocks

As another round, this PR addresses some of the warnings flagged by active_record doctor, i will like to solve all of them but probably will be later next week.

Eduardo-Lpz avatar Oct 17 '24 19:10 Eduardo-Lpz