lob-php icon indicating copy to clipboard operation
lob-php copied to clipboard

Armenia is not supported

Open antennaio opened this issue 1 year ago • 1 comments

Summary

The ISO 3166 country code of Armenia is AM. Armenia is not included in the CountryExtended nor CountryExtendedExpanded enum. Please correct me if it is on purpose and Armenia is indeed an unsupported country.

Expected Behavior

The enums should include AM / ARMENIA as one of the possible values.

https://github.com/lob/lob-php/blob/main/lib/Model/CountryExtended.php https://github.com/lob/lob-php/blob/main/lib/Model/CountryExtendedExpanded.php

Current Behavior

AM / ARMENIA is not a supported country.

Possible Solution

Add AM / ARMENIA as one of the supported countries.

Steps to Reproduce

  1. \OpenAPI\Client\Model\CountryExtended::from('AM')
  2. See exception: "AM" is not a valid backing value for enum OpenAPI\Client\Model\CountryExtended

antennaio avatar Oct 31 '23 11:10 antennaio

I have the same issue, created I PR: https://github.com/lob/lob-php/pull/184

alies-dev avatar Jan 30 '24 14:01 alies-dev