generate-changelog icon indicating copy to clipboard operation
generate-changelog copied to clipboard

[Feature request] cz-emoji support

Open Kristinita opened this issue 7 years ago • 2 comments

1. Request

It would be nice, if generate-changelog will support cz-emoji.

2. Justification

Support smiles in commit messages. cz-emoji — commitizen-compatible npm package.

3. Steps to reproduce

I install commitizen and cz-emoji → I create any commit to my GitHub repository via cz-emoji → I run command changelog -f -.

4. Expected behavior

Successful changelog generation.

5. Actual behavior

Blank changelog, example:

D:\SashaBranchReleaseIt>changelog -f -
#### 2.0.1 (2018-01-29)

Thanks.

Kristinita avatar Jan 29 '18 08:01 Kristinita

Hi @Kristinita, I'm unable to reproduce the issue. Could this be a problem with your environment not being able to display emoji correctly in the shell? I just tested the latest version of generate-changelog in a new, empty repo with emojis in the commit message and it works just fine.

$ yarn add generate-changelog
yarn add v0.27.5
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
warning Your current version of Yarn is out of date. The latest version is "1.3.2" while you're on "0.27.5".
success Saved 4 new dependencies.
├─ [email protected]
├─ [email protected]
├─ [email protected]
└─ [email protected]
Done in 0.74s.
$ git init
Initialized empty Git repository in /private/tmp/emoji-test/.git/
$ git commit -m 'feat(emoji): 🌟 🐞' --allow-empty
[master (root-commit) 7e3f207] feat(emoji): 🌟 🐞
$ git log
commit 7e3f207188f9c2dddf4e63b085a6f2bd24aaca0b
Author: Donald Little <[email protected]>
Date:   Mon Jan 29 12:08:33 2018 -0800

    feat(emoji): 🌟 🐞
$ ./node_modules/generate-changelog/bin/generate --major
$ cat CHANGELOG.md
## 2018-01-29

##### New Features

* **emoji:**  🌟 🐞 (7e3f2071)

dmlittle avatar Jan 29 '18 20:01 dmlittle

@dmlittle, my request not about emoji at all, it about cz-emoji. Do you try reproduce issue, use cz-emoji?

Steps to reproduce

My C:\Users\SashaChernykh\.czrc file:

{ "path": "cz-conventional-changelog", "path": "cz-emoji"}

I run in my git repository folder:

# I make any changes in my repository
D:\SashaBranchReleaseIt>git add .

D:\SashaBranchReleaseIt>git cz
[email protected], [email protected]

? Select the type of change you're committing: fix          🐛  Fixing a bug.
? Specify a scope: examplescope
? Write a short description: Short
? List any issue closed (#1, …):
? Provide a longer description: Longer description
[master 3f494ba] :bug: (examplescope) Short
 1 file changed, 2 insertions(+), 1 deletion(-)

D:\SashaBranchReleaseIt>changelog -f -
#### 2.0.1 (2018-01-30)

Thanks.

Kristinita avatar Jan 30 '18 13:01 Kristinita