garbage-collector icon indicating copy to clipboard operation
garbage-collector copied to clipboard

[BUG] Kol Con Snowglobe and Can of Mixed Everything valuations are inaccurate

Open Shiverwarp opened this issue 11 months ago • 3 comments

Describe the bug Currently potion drops specifically from sneegleeb and CoME are inaccurate because potions that cannot drop are included. For example: extra-strength goo, primitive alien medicine, Atomic Comic

To Reproduce

To see the list of things we're currently counting as able to be dropped:

jsl Item.all().filter( (i) => i.tradeable && i.discardable && (i.inebriety || i.fullness || i.potion), ).sort((a,b) => mallPrice(a) - mallPrice(b)).reverse().slice(0,19);

We can see potions that never actually drop.

Expected behavior Only include potions that can actually drop

Additional context

The best solution I can think of is to try to build a list of confirmed possible drops from gleeb/CoME by parsing session logs, and then creating a restricted list of potions not to include in the valuation.

Shiverwarp avatar Mar 25 '24 00:03 Shiverwarp