bot icon indicating copy to clipboard operation
bot copied to clipboard

Add typescript support

Open grunch opened this issue 3 years ago • 5 comments

Add full Typescript support while preserving the possibility of using Javascript files as we are using currently

grunch avatar Apr 23 '22 18:04 grunch

@grunch I guess this should have been closed as "not planned" instead of "completed"?

If yes, why?

siwatanejo avatar May 03 '23 03:05 siwatanejo

I don't remember if we had close as not planned button at that time, it was closed becasue I'm not going to do it and I didn't find someone else to do it

grunch avatar May 03 '23 09:05 grunch

Ok thanks for the info @grunch. Now, if I and my team were to open a PR that covers this, would you welcome it?

siwatanejo avatar May 04 '23 06:05 siwatanejo

yes I reopened, all collaboration is welcome, the thing is the bot is being used by many people simultaneously and we need to be very careful on any change, to accomplish a task like this one we need to split it on smaller PRs that way is easy to test it

grunch avatar May 04 '23 12:05 grunch

My team started to look into this but found the first roadblock: any PR open to the project will fail CI because integration tests are failing (and they are not run in push event so this is only caught at PR time, not when normal maintainers push directly to master). My team has opened bug & and PR to try to address this, can you follow-up or help? Otherwise we're stuck. Thanks

siwatanejo avatar May 19 '23 04:05 siwatanejo