Linus Jahn

Where are queued connections done in QXmpp?

Those signals don't use queued connections, because both OmemoManager and OmemoManagerPrivate are always on the same thread.

And the other (easier) option to solve this issue is probably to use quint32 instead of uint32_t, I guess?

[QXmppMovedManager: Fix doxygen missing documentation](https://github.com/qxmpp-project/qxmpp/pull/657/commits/2c06651baf891939af8a30a28bd8b079939d0381) I fixed this on master now without using QXmppClient::EmptyResult. The alias `QXmppClient::EmptyResult` should not be used in other classes as QXmppClient isn't really the right...

> Util: Add more helpers Can you change the commit description so that it properly describes the changes (not just "more utils"), e.g. `tests: util: Add xmlToFormattedByteArray() func`.

> QXmppRosterManager: Handle better mix roster entries Please include that this is only about data import/export in the commit description. And in the long description you could note what is...

So the issue is that an attacker could gain information about the real hmac because of the non-constant time comparison, right? I'd guess that this isn't realistic when triggering this...

One implication would be that you need an account on invent.kde.org instead of github.com to report issues and contribute. Maybe a disadvantage for some less-involved users who would like to...

There's https://invent.kde.org/teams/migrations/qxmpp now with a proper import. Comments are owned by new placeholder users which can later be linked to real accounts on invent again, so everything looks like the...