Laurențiu Nicola

Results 765 comments of Laurențiu Nicola

You can run the failing test and add the modified file.

Let's wait a bit and see if the formatting changes bother anyone :sweat_smile:.

Well, some parts look better, others don't, and it's overall larger. But if it was written like this, we probably wouldn't have bothered to change it to `match`. So I'm...

I learned a word for this today: [Verschlimmbesserung](https://en.wiktionary.org/wiki/Verschlimmbesserung).

> Additionally, I think there may be a few other platforms that are available in [tier 2](https://doc.rust-lang.org/nightly/rustc/platform-support.html#tier-2-with-host-tools), though I'm not sure if there is much demand for those. We do...

I think we can go forward with the plan in https://github.com/rust-lang/rust-analyzer/issues/12432#issuecomment-1147711890, including dropping the suffix.

Not only that, but I think we got the proc macro server binary and corresponding RA changes into the beta branch.

It might still make sense to move down traits without associated constants, since it's not that common to invoke methods like that.

There is a "view dependency graph" command which could serve as inspiration.