lnbits icon indicating copy to clipboard operation
lnbits copied to clipboard

fix issue: #897, ugly memo in payments list

Open dni opened this issue 3 years ago • 3 comments

Fixes: #897

dni avatar Aug 20 '22 08:08 dni

screenshot-1660985475

memo is now a 1 liner

before

screenshot-1660990743

dni avatar Aug 20 '22 09:08 dni

Codecov Report

Merging #918 (fccc6bb) into main (ae1a2ac) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #918   +/-   ##
=======================================
  Coverage   51.84%   51.84%           
=======================================
  Files         225      225           
  Lines       12351    12351           
=======================================
  Hits         6403     6403           
  Misses       5948     5948           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 20 '22 09:08 codecov-commenter

another addition, don' t use columns for payment-details

before

screenshot-1660987304

after

screenshot-1660988731 screenshot-1660988722

i leave this pr as is, i think its subjectively better than before, but i do not want get into any design discussion :).

dni avatar Aug 20 '22 09:08 dni

thats a long phone you have there!

arcbtc avatar Sep 30 '22 12:09 arcbtc

Can you test and post images from a mobile device.

arcbtc avatar Sep 30 '22 12:09 arcbtc

Be good to get this merged, but it needs compacting for a smaller screen Add some v-if="gt-md", or something similar to some padding elements to tuck it all in 👍.

arcbtc avatar Dec 07 '22 11:12 arcbtc