Louis Moureaux

Results 186 comments of Louis Moureaux

Strange, the color picker is parented correctly on Linux. Might be a limitation of Qt or the window manager on Mac OS (dialog in dialog).

List with most of them: ``` $ grep -r setStandardButtons client/ tools/ client/cityrep.cpp: ask->setStandardButtons(QMessageBox::Cancel | QMessageBox::Ok); client/dialogs.cpp: msg->setStandardButtons(QMessageBox::Ok); client/dialogs.cpp: ask->setStandardButtons(QMessageBox::Cancel | QMessageBox::Ok); client/dialogs.cpp: impossible->setStandardButtons(QMessageBox::Ok); client/dialogs.cpp: ask->setStandardButtons(QMessageBox::Cancel | QMessageBox::Ok); client/dialogs.cpp: too_much->setStandardButtons(QMessageBox::Ok);...

Looks like the standard practice is to use relative paths for the command and icon

Well, it works as documented and absolute paths allow installing several instances of Freeciv21. Closing.

More context: * Unfortunately this deprecation warning doesn't support `Q_DISABLE_DEPRECATED_BEFORE` (or similar) * We used to need Qt 5.10 for the server. We can now require 5.12 (but it still...

Using this issue to document overall progress. # Improved I don't think I caught all 92 leaks but at least 4 per tileset load. ``` Direct leak of 2944 byte(s)...

I would only drop those items that are not enabled in the rules (for instance, the spaceship when it's disabled). Someone could wonder why the button is not there and...

The idea is be to eventually generate `qhp` files for the [Help Framework](https://doc.qt.io/qt-6/qthelp-framework.html), using Sphinx' built-in ability to do so. We'd then add a simple `qhp` viewer to the client...

Can't reproduce in a new game on Linux, but I *think* I saw something similar once. But clicking on a unit restarted things as normal...

Postponing because I can't figure out how to reproduce.