Louis Moureaux

https://docs.microsoft.com/en-us/windows/security/threat-protection/microsoft-defender-smartscreen/microsoft-defender-smartscreen-overview#submit-files-to-microsoft-defender-smartscreen-for-review

> Drag to move around map I don't really like this one. Dragging means you need to move the move twice as much (back and forth). We can have specific...

Good catch. Maybe the shortcuts PR already fixed it, but I totally see how it can happen.

Relevant code: https://github.com/longturn/freeciv21/blob/4fed71bea81cd527472ef64f4add0d120615ef3a/client/mapctrl.cpp#L427

`clang-tidy` can do it: https://clang.llvm.org/extra/clang-tidy/checks/readability/identifier-naming.html https://sarcasm.github.io/notes/dev/clang-tidy.html

When loading the save in a debug build, I get: ``` [critical] freeciv21-server (/home/louis/Personal/freeciv21/server/sanitycheck.cpp:92) - T022: Assertion pterrain->mining_result == pterrain failed [critical] freeciv21-server (/home/louis/Personal/freeciv21/server/sanitycheck.cpp:92) - T022: ( 46, 27) at...

This is caused by two AI cities building `==Building complete==` while producing negative shields.

These two cities don't manage to disband their units (doing it manually works). In such a case, normally a citizen gets killed instead (one per shield!), but a bug prevents...

The ruleset lacks the [`missing_unit_upkeep`](https://freeciv.fandom.com/wiki/How_to_update_a_ruleset_from_2.6_to_3.0#Missing_unit_upkeep_consequences) section in `units.ruleset`, thus no action is considered when attempting to disband units for upkeep reasons. How was it produced? Is this something missing from...

Current status: * https://github.com/longturn/freeciv/commit/c5a782697f - `Action_Odds_Pct` provides this functionality * https://github.com/longturn/freeciv/commit/c64964fb75 - Already ported * https://github.com/longturn/freeciv/commit/416191fd0e - Already ported * https://github.com/longturn/freeciv/commit/8691fa8e38 - To do * https://github.com/longturn/freeciv/commit/88bfdc1dd4 - To do *...