Lorenzo Moneta

Results 68 comments of Lorenzo Moneta

@phsft-bot build just on ROOT-ubuntu2204/default with flags -Dtmva-sofie=On

Thank you Sanjiban, I will fix the other files as well!

@phsft-bot build just on ROOT-ubuntu2204/cxx17, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/nortcxxmod

ROOT::Fit::FitResult::Chi2() returns the chi2 after fitting, `TH1::Chisquare` calls the function `ROOT::Fit::Chisquare` which compute the chi2 with an arbitrary function and histogram. The implementation is the same using the `ROOT::Fit::Chi2FCN` class.

This has been fixed in 6.26.08 and in 6.28 the namespace TMVA::Experimental::SOFIE::INTERNAL has been removed in 6.28

Yes, this is the list of dependencies, but they are optional, we should not emit an error if the package is not installed

For TMVA nothing, if they are not there the corresponding tests are not run. Everything is protected. But I think if we add in the requirements.txt and the package is...

@dpiparo: I have addressed one of your comment. The other ones (e.g. on the arguments passed by values) I would prefer to address in a separate PR, since it affects...

@guitargeek : I will soon open a PR adding this migration.