Luca Mondada
Luca Mondada
After many discussions, I have "boiled down" the choices to the following flowchart: ```mermaid flowchart LR BB{Dynamic phase?} BB -->|No| Metadata BB -->|Yes| A A{Preserve phase by default?} -->|No| B{HUGR...
>we just say that DCE is a non-phase-preserving pass Very good point. Will add. EDIT: updated the flowchart and renamed "Order edges" solution to "Single AddPhase op".
Thanks for reporting it. I'll see about fixing this in cudaq.
Hi Alan! Thank you so much, I'll have a look and answer tomorrow, hope that's okay!! Sorry for the delay
I can't change the assigned reviewer. @doug-q feel free to have a look at this yourself or pass it on to @acl-cqc
The reason for the reduced coverage in `tket/src/rewrite/strategy.rs` is the temporarily ignored test. This will be reactivated with the next PR.
> I've skipped the parametrization of Rewriter since that wasn't used anywhere Thank you so much Alan! The parametrization will be required for the next PR I'll open, but I...
Oh and ~personal agenda~ hot take: make `ResourceScope` the new `Circuit` 👀 see https://github.com/CQCL/tket2/pull/1052
I don't understand what/why CI is failing... any ideas?
Suggested naming scheme (pending #588) - `PatchGraph`: a whole bunch of `Patch`es that are the result of applying rewrites, possibly conflicting. It's main purpose is to keep Rcs to the...