did remove crashing asserts

[alekseykolchanov]

In production we had too many crashes in sendPing function. Crashlytics shows crashes on 'assert()' put in sendPing function

There are two issues, I believe, related to those asserts: https://github.com/lmirosevic/GBPing/issues/36 https://github.com/lmirosevic/GBPing/issues/34

[melon8]

I think you don't need return in line 503. Because if bytesSent < 0, it will go to call the delegate method "ping:didFailWithError:" in line 615. The delegate method will output more information.

[lawmaestro]

Just run into this issue! Is there any update on the status of this PR? Thanks.

[alekseykolchanov]

@melon8 Thank you for your suggestion. There is a 'switch' on line 493. In the case statements author defines what type of packet to send and invokes the code which sends the packet and initiates local variable 'packet' (defined on line 487) Since author uses that 'packet' variable later in the method and initially put assert for 'default' case on line 500, I assume it is safer to just return from the method

[alekseykolchanov]

@lawmaestro Hello! There were no updates to the PR

[lawmaestro]

I meant is the PR likely to get merged shortly? Just it addresses an issue I’m running into. Thanks.

[Roman-Scherbakov]

@alekseykolchanov is this pull request fix crashes? Because it is reproduced in very rare cases. And are you sure that this change fix asserts: #36 #34?

[robinschmied]

We can't reproduce the issue, but we are getting crash reports from those 2 lines. We believe that the changes would fix the issue.